Pass --skip to HashcatStatus for newer versions - #74
Conversation
If get_progress or get_progress_total is called with absolute=True, add the skip amount to the result. This restores behaviour desired in hashcat/hashcat#4805
Also move version threshold to 7.2
|
Maybe this is not necessary, as we could use CURKU instead of PROGRESS field to get the absolute position in the search space? |
Using the CURKU seems to be the intended way from hashcat to distribute work. So i agree that using that would be the most straight forward solution |
|
Thanks for working on a fix to adapt to the change in hashcat. There is a problem though we currently have when dealing with this. The "unit" of the values of CURKU, skip and limit is not the same as the one used in PROGRESS. That's why I think this does not work properly when we just add the skip value to the progress value. The values of CURKU, skip and limit are in the units of steps on the value of --keyspace of the task (hashcat keyspace, not actual number of candidates). Edit: I think it's a bit nontransparent to change the behavior in the getters of the status. Actually, we do quite some calculations in hashcat_cracker.py:L341+ to handle the old behavior (change from one scale to the other), so it would make more sense to handle the two cases there (and the new case will be quite a bit more simple than the current way). |
3 participants
As observed in hashcat/hashcat#4805, the --machine-readable PROGRESS format has changed to not include the --skip amount anymore.
This fix ensures that the old functionality is preserved for applications querying these progress (current & total) fields.